[Intel-gfx] [PATCH 2/5] drm/i915: replace IS_GEN<N> with IS_GEN(..., N)

Jani Nikula jani.nikula at linux.intel.com
Thu Nov 1 11:17:07 UTC 2018


On Thu, 01 Nov 2018, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
> Now that IS_GEN can accept 1 or 2 parameters, replace the use
> of IS_GEN<N> by passing N as argument. This was generated with:

Ignoring the naming and all the contentious stuff about using the same
macro for ranges and single gen, I think there's a useful discussion to
be had here about defining IS_GEN<N> macros for every new generation
vs. passing the gen to a macro.

I do prefer one IS_GEN(i915, N) over N instances of IS_GEN<N>(i915).

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list