[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] locking/lockdep: restore cross-release checks
Patchwork
patchwork at emeril.freedesktop.org
Fri Nov 2 09:43:11 UTC 2018
== Series Details ==
Series: series starting with [01/12] locking/lockdep: restore cross-release checks
URL : https://patchwork.freedesktop.org/series/51923/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
11e54ecf16c4 locking/lockdep: restore cross-release checks
-:8: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 527187d28569 ("locking/lockdep: Remove cross-release leftovers")'
#8:
527187d28569 ("locking/lockdep: Remove cross-release leftovers")
-:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
dba04eb76df9 ("locking/Documentation: Remove stale crossrelease_fullstack parameter")
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit dba04eb76df9 ("locking/Documentation: Remove stale crossrelease_fullstack parameter")'
#9:
dba04eb76df9 ("locking/Documentation: Remove stale crossrelease_fullstack parameter")
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks")'
#10:
e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks")
-:66: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#66:
new file mode 100644
-:642: WARNING:TYPO_SPELLING: 'prefered' may be misspelled - perhaps 'preferred'?
#642: FILE: Documentation/locking/crossrelease.txt:572:
+deadlock or its possibility sooner. So the former way would be prefered
-:814: WARNING:TYPO_SPELLING: 'implmentation' may be misspelled - perhaps 'implementation'?
#814: FILE: Documentation/locking/crossrelease.txt:744:
+like how lockdep handles held_locks. Lockless implmentation is important
-:837: WARNING:TYPO_SPELLING: 'occured' may be misspelled - perhaps 'occurred'?
#837: FILE: Documentation/locking/crossrelease.txt:767:
+that it has not occured yet, lockdep should consider all possible
-:984: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#984: FILE: include/linux/completion.h:53:
+#define init_completion_map(x, m) \
+do { \
+ lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \
+ (m)->name, (m)->key, 0); \
+ __init_completion(x); \
+} while (0)
-:984: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'm' - possible side-effects?
#984: FILE: include/linux/completion.h:53:
+#define init_completion_map(x, m) \
+do { \
+ lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \
+ (m)->name, (m)->key, 0); \
+ __init_completion(x); \
+} while (0)
-:991: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#991: FILE: include/linux/completion.h:60:
+#define init_completion(x) \
+do { \
+ static struct lock_class_key __key; \
+ lockdep_init_map_crosslock((struct lockdep_map *)&(x)->map, \
+ "(completion)" #x, \
+ &__key, 0); \
+ __init_completion(x); \
+} while (0)
-:1008: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'work' - possible side-effects?
#1008: FILE: include/linux/completion.h:77:
+#define COMPLETION_INITIALIZER(work) \
+ { 0, __WAIT_QUEUE_HEAD_INITIALIZER((work).wait), \
+ STATIC_CROSS_LOCKDEP_MAP_INIT("(completion)" #work, &(work)) }
-:1106: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'?
#1106: FILE: include/linux/lockdep.h:310:
+ * Seperate stack_trace data. This will be used at commit step.
-:1112: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'?
#1112: FILE: include/linux/lockdep.h:316:
+ * Seperate hlock instance. This will be used at commit step.
-:1140: WARNING:TYPO_SPELLING: 'Seperate' may be misspelled - perhaps 'Separate'?
#1140: FILE: include/linux/lockdep.h:344:
+ * Seperate hlock instance. This will be used at commit step.
-:1163: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#1163: FILE: include/linux/lockdep.h:561:
+extern void lockdep_init_map_crosslock(struct lockdep_map *lock,
-:1167: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#1167: FILE: include/linux/lockdep.h:565:
+extern void lock_commit_crosslock(struct lockdep_map *lock);
-:1187: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#1187: FILE: include/linux/lockdep.h:585:
+extern void crossrelease_hist_start(enum xhlock_context_t c);
-:1188: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#1188: FILE: include/linux/lockdep.h:586:
+extern void crossrelease_hist_end(enum xhlock_context_t c);
-:1189: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#1189: FILE: include/linux/lockdep.h:587:
+extern void lockdep_invariant_state(bool force);
-:1190: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#1190: FILE: include/linux/lockdep.h:588:
+extern void lockdep_init_task(struct task_struct *task);
-:1191: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#1191: FILE: include/linux/lockdep.h:589:
+extern void lockdep_free_task(struct task_struct *task);
-:1306: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1306: FILE: kernel/locking/lockdep.c:1158:
+ printk(" Possible unsafe locking scenario by crosslock:\n\n");
-:1307: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1307: FILE: kernel/locking/lockdep.c:1159:
+ printk(" CPU0 CPU1\n");
-:1308: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1308: FILE: kernel/locking/lockdep.c:1160:
+ printk(" ---- ----\n");
-:1309: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1309: FILE: kernel/locking/lockdep.c:1161:
+ printk(" lock(");
-:1311: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
#1311: FILE: kernel/locking/lockdep.c:1163:
+ printk(KERN_CONT ");\n");
-:1311: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible
#1311: FILE: kernel/locking/lockdep.c:1163:
+ printk(KERN_CONT ");\n");
-:1312: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1312: FILE: kernel/locking/lockdep.c:1164:
+ printk(" lock(");
-:1314: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
#1314: FILE: kernel/locking/lockdep.c:1166:
+ printk(KERN_CONT ");\n");
-:1314: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible
#1314: FILE: kernel/locking/lockdep.c:1166:
+ printk(KERN_CONT ");\n");
-:1315: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1315: FILE: kernel/locking/lockdep.c:1167:
+ printk(" lock(");
-:1317: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
#1317: FILE: kernel/locking/lockdep.c:1169:
+ printk(KERN_CONT ");\n");
-:1317: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible
#1317: FILE: kernel/locking/lockdep.c:1169:
+ printk(KERN_CONT ");\n");
-:1318: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1318: FILE: kernel/locking/lockdep.c:1170:
+ printk(" unlock(");
-:1320: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
#1320: FILE: kernel/locking/lockdep.c:1172:
+ printk(KERN_CONT ");\n");
-:1320: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible
#1320: FILE: kernel/locking/lockdep.c:1172:
+ printk(KERN_CONT ");\n");
-:1321: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1321: FILE: kernel/locking/lockdep.c:1173:
+ printk("\n *** DEADLOCK ***\n\n");
-:1323: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1323: FILE: kernel/locking/lockdep.c:1175:
+ printk(" Possible unsafe locking scenario:\n\n");
-:1324: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1324: FILE: kernel/locking/lockdep.c:1176:
+ printk(" CPU0 CPU1\n");
-:1325: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1325: FILE: kernel/locking/lockdep.c:1177:
+ printk(" ---- ----\n");
-:1326: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1326: FILE: kernel/locking/lockdep.c:1178:
+ printk(" lock(");
-:1328: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
#1328: FILE: kernel/locking/lockdep.c:1180:
+ printk(KERN_CONT ");\n");
-:1328: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible
#1328: FILE: kernel/locking/lockdep.c:1180:
+ printk(KERN_CONT ");\n");
-:1329: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1329: FILE: kernel/locking/lockdep.c:1181:
+ printk(" lock(");
-:1331: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
#1331: FILE: kernel/locking/lockdep.c:1183:
+ printk(KERN_CONT ");\n");
-:1331: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible
#1331: FILE: kernel/locking/lockdep.c:1183:
+ printk(KERN_CONT ");\n");
-:1332: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1332: FILE: kernel/locking/lockdep.c:1184:
+ printk(" lock(");
-:1334: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
#1334: FILE: kernel/locking/lockdep.c:1186:
+ printk(KERN_CONT ");\n");
-:1334: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible
#1334: FILE: kernel/locking/lockdep.c:1186:
+ printk(KERN_CONT ");\n");
-:1335: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1335: FILE: kernel/locking/lockdep.c:1187:
+ printk(" lock(");
-:1337: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_cont([subsystem]dev, ... then dev_cont(dev, ... then pr_cont(... to printk(KERN_CONT ...
#1337: FILE: kernel/locking/lockdep.c:1189:
+ printk(KERN_CONT ");\n");
-:1337: WARNING:LOGGING_CONTINUATION: Avoid logging continuation uses where feasible
#1337: FILE: kernel/locking/lockdep.c:1189:
+ printk(KERN_CONT ");\n");
-:1338: WARNING:PRINTK_WITHOUT_KERN_LEVEL: printk() should include KERN_<LEVEL> facility level
#1338: FILE: kernel/locking/lockdep.c:1190:
+ printk("\n *** DEADLOCK ***\n\n");
-:1434: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1434: FILE: kernel/locking/lockdep.c:3287:
+void lockdep_init_map_crosslock(struct lockdep_map *lock, const char *name,
+ struct lock_class_key *key, int subclass)
-:1819: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#1819: FILE: kernel/locking/lockdep.c:4945:
+ if (nr_stack_trace_entries >= MAX_STACK_TRACE_ENTRIES-1) {
^
-:1846: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1846: FILE: kernel/locking/lockdep.c:4972:
+ if (!add_chain_cache_classes(xid, pid, xhlock->hlock.irq_context,
+ chain_key))
-:1981: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*task->xhlocks)...) over kzalloc(sizeof(struct hist_lock)...)
#1981: FILE: kernel/locking/lockdep.c:5107:
+ task->xhlocks = kzalloc(sizeof(struct hist_lock) * MAX_XHLOCKS_NR,
-:1989: WARNING:TYPO_SPELLING: 'Diable' may be misspelled - perhaps 'Disable'?
#1989: FILE: kernel/locking/lockdep.c:5115:
+ /* Diable crossrelease for current */
-:2061: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 3 errors, 42 warnings, 15 checks, 1947 lines checked
d5e92af47f86 kthread: finer-grained lockdep/cross-release completion
-:49: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#49: FILE: include/linux/kthread.h:11:
+struct task_struct *_kthread_create_on_node(int (*threadfn)(void *data),
void *data,
-:70: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#70: FILE: include/linux/kthread.h:39:
+struct task_struct *_kthread_create_on_cpu(int (*threadfn)(void *data),
void *data,
-:108: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#108: FILE: include/linux/kthread.h:206:
+_kthread_create_worker_on_cpu(int cpu, unsigned int flags,
+ struct lock_class_key *exited_key,
-:139: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#139: FILE: kernel/kthread.c:234:
+ lockdep_init_map_crosslock(&self->exited.map.map,
+ "(kthread completion)->exited",
-:139: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'kthread', this function's name, in a string
#139: FILE: kernel/kthread.c:234:
+ "(kthread completion)->exited",
-:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#143: FILE: kernel/kthread.c:238:
+ lockdep_init_map_crosslock(&self->parked.map.map,
+ "(kthread completion)->parked",
-:143: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'kthread', this function's name, in a string
#143: FILE: kernel/kthread.c:238:
+ "(kthread completion)->parked",
-:209: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#209: FILE: kernel/kthread.c:454:
+struct task_struct *_kthread_create_on_cpu(int (*threadfn)(void *data),
void *data, unsigned int cpu,
-:297: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 3 warnings, 6 checks, 240 lines checked
21688b527b8d lockdep: Remove GFP_NOLOCKDEP annotation
-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7e7844226f10 ("lockdep: allow to disable reclaim lockup detection")'
#6:
This was originally added in 7e7844226f10 ("lockdep: allow to disable
-:70: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 32 lines checked
80a1555c61a6 kernel/lockdep: Make cross-release a config option
-:74: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 42 lines checked
7e4ead273b8d mm: Check if mmu notifier callbacks are allowed to fail
-:31: ERROR:SPACING: space required after that ',' (ctx:VxV)
#31: FILE: mm/mmu_notifier.c:193:
+ WARN(blockable,"%pS callback failure not allowed\n",
^
-:35: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 8 lines checked
82d4533cb449 mm, notifier: Catch sleeping/blocking for !blockable
-:44: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 14 lines checked
d532af81d6ac mm, notifier: Add a lockdep map for invalidate_range_start
-:85: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 34 lines checked
27877d64e988 dma-fence: cross-release annotations
-:40: CHECK:LINE_SPACING: Please don't use multiple blank lines
#40: FILE: drivers/dma-buf/dma-fence.c:33:
+
-:100: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#100: FILE: include/linux/dma-fence.h:45:
+}
+static inline void dma_fence_wait_release(void)
-:104: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#104: FILE: include/linux/dma-fence.h:49:
+}
+static inline void dma_fence_wait_release_commit(void)
-:122: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 3 checks, 78 lines checked
4c2654cb3a9e reservation: Annotate dma_fence waits
6d110e32e829 drm/i915: Annotate dma_fence waits
-:59: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 37 lines checked
db3377b5b42b drm/i915: annotate intel_atomic_commit_fence_wait
-:66: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 14 lines checked
262367da82b7 HAX FOR CI: Enable cross-release
-:22: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
More information about the Intel-gfx
mailing list