[Intel-gfx] [PATCH] drm/i915: fix subslice mask array size

Lionel Landwerlin lionel.g.landwerlin at intel.com
Tue Nov 6 18:33:49 UTC 2018


On 06/11/2018 18:29, Daniele Ceraolo Spurio wrote:
> We have a subslice mask per slice, not per subslice.
> MAX_SUBSLICES > MAX_SLICES, so the wrong size didn't cause any issue
> apart from using extra memory.
>
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

Indeed!
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

Thanks,

-
Lionel


> ---
>   drivers/gpu/drm/i915/intel_device_info.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
> index 86ce1db1b33a..88f97210dc49 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -124,7 +124,7 @@ enum intel_ppgtt {
>   
>   struct sseu_dev_info {
>   	u8 slice_mask;
> -	u8 subslice_mask[GEN_MAX_SUBSLICES];
> +	u8 subslice_mask[GEN_MAX_SLICES];
>   	u16 eu_total;
>   	u8 eu_per_subslice;
>   	u8 min_eu_in_pool;




More information about the Intel-gfx mailing list