[Intel-gfx] [PATCH] drm/i915/query: fix subslice length

[Tvrtko Ursulin]

On 09/11/2018 00:40, Daniele Ceraolo Spurio wrote:
> We dump the info as an array of u8, so we want to know the length
> in number of bytes. Current code is still safe because the
> variable we use BITS_PER_TYPE on is a u8.
> 
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> ---
>   drivers/gpu/drm/i915/i915_query.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_query.c b/drivers/gpu/drm/i915/i915_query.c
> index 5821002cad42..6fc4b8eeab42 100644
> --- a/drivers/gpu/drm/i915/i915_query.c
> +++ b/drivers/gpu/drm/i915/i915_query.c
> @@ -27,8 +27,7 @@ static int query_topology_info(struct drm_i915_private *dev_priv,
>   
>   	slice_length = sizeof(sseu->slice_mask);
>   	subslice_length = sseu->max_slices *
> -		DIV_ROUND_UP(sseu->max_subslices,
> -			     BITS_PER_TYPE(sseu->subslice_mask[0]));
> +		DIV_ROUND_UP(sseu->max_subslices, BITS_PER_BYTE);
>   	eu_length = sseu->max_slices * sseu->max_subslices *
>   		DIV_ROUND_UP(sseu->max_eus_per_subslice, BITS_PER_BYTE);
>   
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko