[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gen11: Preempt-to-idle support in execlists. (rev8)

Patchwork patchwork at emeril.freedesktop.org
Fri Nov 9 18:17:44 UTC 2018


== Series Details ==

Series: drm/i915/gen11: Preempt-to-idle support in execlists. (rev8)
URL   : https://patchwork.freedesktop.org/series/40747/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
565cd7090a44 drm/i915/icl: Preempt-to-idle support in execlists.
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18: 
The advantage of this new preemption path is that one less context switch is

-:153: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!execlists->ctrl_reg"
#153: FILE: drivers/gpu/drm/i915/intel_lrc.c:514:
+		GEM_BUG_ON(execlists->ctrl_reg == NULL);

-:229: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#229: FILE: drivers/gpu/drm/i915/intel_lrc.c:952:
+		if ((status & GEN8_CTX_STATUS_IDLE_ACTIVE) &&
+		     (status & GEN11_CTX_STATUS_PREEMPT_IDLE)) {

-:263: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#263: FILE: drivers/gpu/drm/i915/intel_lrc.c:982:
+		    buf[2*head + 1] == execlists->preempt_complete_status)) {
 		         ^

total: 0 errors, 1 warnings, 3 checks, 187 lines checked



More information about the Intel-gfx mailing list