[Intel-gfx] [PATCH] drm/i915: fix broadwell EU computation

Chris Wilson chris at chris-wilson.co.uk
Mon Nov 12 15:44:44 UTC 2018


Quoting Lionel Landwerlin (2018-11-12 12:39:31)
> subslice_mask is an array indexed by slice, not subslice.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
> ---
>  drivers/gpu/drm/i915/intel_device_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 89ed3a84a4fa..ceecb5bd5226 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -474,7 +474,7 @@ static void broadwell_sseu_info_init(struct drm_i915_private *dev_priv)
>                         u8 eu_disabled_mask;
>                         u32 n_disabled;
>  
> -                       if (!(sseu->subslice_mask[ss] & BIT(ss)))
> +                       if (!(sseu->subslice_mask[s] & BIT(ss)))

Tallies up with the other users.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list