[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 15 12:57:58 UTC 2018


== Series Details ==

Series: series starting with [1/5] drm/i915: extract fixed point math to i915_fixed.h
URL   : https://patchwork.freedesktop.org/series/52528/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6a9582cd3a2e drm/i915: extract fixed point math to i915_fixed.h
-:169: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#169: 
new file mode 100644

-:179: WARNING:NEW_TYPEDEFS: do not add new typedefs
#179: FILE: drivers/gpu/drm/i915/i915_fixed.h:6:
+typedef struct {

-:237: WARNING:LINE_SPACING: Missing a blank line after declarations
#237: FILE: drivers/gpu/drm/i915/i915_fixed.h:64:
+	uint_fixed_16_16_t fp;
+	WARN_ON(val > U32_MAX);

-:238: CHECK:SPACING: No space is necessary after a cast
#238: FILE: drivers/gpu/drm/i915/i915_fixed.h:65:
+	fp.val = (uint32_t) val;

-:253: CHECK:SPACING: No space is necessary after a cast
#253: FILE: drivers/gpu/drm/i915/i915_fixed.h:80:
+	intermediate_val = (uint64_t) val * mul.val;

-:256: CHECK:SPACING: No space is necessary after a cast
#256: FILE: drivers/gpu/drm/i915/i915_fixed.h:83:
+	return (uint32_t) intermediate_val;

-:264: CHECK:SPACING: No space is necessary after a cast
#264: FILE: drivers/gpu/drm/i915/i915_fixed.h:91:
+	intermediate_val = (uint64_t) val.val * mul.val;

-:286: CHECK:SPACING: No space is necessary after a cast
#286: FILE: drivers/gpu/drm/i915/i915_fixed.h:113:
+	return (uint32_t) interm_val;

-:294: CHECK:SPACING: No space is necessary after a cast
#294: FILE: drivers/gpu/drm/i915/i915_fixed.h:121:
+	intermediate_val = (uint64_t) val * mul.val;

-:303: CHECK:SPACING: No space is necessary after a cast
#303: FILE: drivers/gpu/drm/i915/i915_fixed.h:130:
+	interm_sum = (uint64_t) add1.val + add2.val;

-:313: CHECK:SPACING: No space is necessary after a cast
#313: FILE: drivers/gpu/drm/i915/i915_fixed.h:140:
+	interm_sum = (uint64_t) add1.val + interm_add2.val;

total: 0 errors, 3 warnings, 8 checks, 293 lines checked
972f5010d577 drm/i915/fixed: prefer kernel types over stdint types
23dc0f69fbfe drm/i915/fixed: simplify FP_16_16_MAX definition
f26dbee44029 drm/i915/fixed: simplify is_fixed16_zero()
7abd76bd22f0 drm/i915/fixed: cosmetic cleanup



More information about the Intel-gfx mailing list