[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for CRTC background color (rev3)

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 15 22:25:36 UTC 2018


== Series Details ==

Series: CRTC background color (rev3)
URL   : https://patchwork.freedesktop.org/series/50834/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8424c4b432e2 drm/i915: Force background color to black for gen9+ (v2)
05fa1ef11dab drm: Add CRTC background color property (v2)
-:156: WARNING:BOOL_BITFIELD: Avoid using bool as bitfield.  Prefer bool bitfields as unsigned int or u<8|16|32>
#156: FILE: include/drm/drm_crtc.h:175:
+	bool bgcolor_changed : 1;

-:224: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'shift' - possible side-effects?
#224: FILE: include/uapi/drm/drm_mode.h:912:
+#define DRM_ARGB_COMP(c, shift, numbits) \
+	(__u16)(((c) & 0xFFFFull << (shift)) >> ((shift) + 16 - (numbits)))

total: 0 errors, 1 warnings, 1 checks, 145 lines checked
8772f8932af9 drm/i915/gen9+: Add support for pipe background color (v3)



More information about the Intel-gfx mailing list