[Intel-gfx] "drm/i915: Use the correct crtc when sanitizing plane mapping" seems to cause the readback plane state to always be 0

[Hans de Goede]

Hi,

On 20-11-18 12:28, Ville Syrjälä wrote:
> On Mon, Nov 19, 2018 at 11:47:00PM +0100, Hans de Goede wrote:
>> Hi Ville,
>>
>> While debugging the briefly purple screen on DSI panels issue for
>> which I just send a revert, I also noticed something odd with
>> your commit 9b27390139db ("drm/i915: Use the correct crtc when
>> sanitizing plane mapping").
>>
>> When comparing drm.debug=0x1e logs between 4.19 and 4.20-rc1
>> I noticed that this bit of the initial hw state readback logging
>> in 4.19:
>>
>> [drm:intel_modeset_setup_hw_state [i915]] pipe B active planes 0x1
>> [drm:intel_modeset_setup_hw_state [i915]] pipe B active planes 0x1
>> [drm:intel_modeset_setup_hw_state [i915]] pipe B active planes 0x1
>> [drm:intel_modeset_setup_hw_state [i915]] pipe B active planes 0x1
>>
>> Changed to:
>>
>> [drm:intel_modeset_setup_hw_state [i915]] pipe B active planes 0x0
>> [drm:intel_modeset_setup_hw_state [i915]] pipe B active planes 0x0
>> [drm:intel_modeset_setup_hw_state [i915]] pipe B active planes 0x0
>> [drm:intel_modeset_setup_hw_state [i915]] pipe B active planes 0x0
> 
> That debug message is just garbage now. I removed it in the following
> commit.

Ah, ok. Thank you for explaining this.

Regards,

Hans