[Intel-gfx] [v3 2/3] drm: Add DP colorspace property

[Ville Syrjälä]

On Tue, Nov 20, 2018 at 02:16:38PM +0000, Shankar, Uma wrote:
> 
> 
> >-----Original Message-----
> >From: Chris Wilson [mailto:chris at chris-wilson.co.uk]
> >Sent: Tuesday, November 20, 2018 7:41 PM
> >To: Shankar, Uma <uma.shankar at intel.com>; dri-devel at lists.freedesktop.org;
> >intel-gfx at lists.freedesktop.org
> >Cc: Syrjala, Ville <ville.syrjala at intel.com>; jonas at kwiboo.se;
> >hansverk at cisco.com; Shankar, Uma <uma.shankar at intel.com>; Lankhorst,
> >Maarten <maarten.lankhorst at intel.com>
> >Subject: Re: [v3 2/3] drm: Add DP colorspace property
> >
> >Quoting Uma Shankar (2018-11-20 14:22:10)
> >> @@ -1457,6 +1480,18 @@ int drm_mode_create_colorspace_property(struct
> >drm_connector *connector)
> >>                         return -ENOMEM;
> >>
> >>                 dev->mode_config.hdmi_colorspace_property = prop;
> >> +       } else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP
> >||
> >> +               connector->connector_type ==
> >DRM_MODE_CONNECTOR_DisplayPort) {
> >> +               if (dev->mode_config.dp_colorspace_property)
> >> +                       return 0;
> >> +
> >> +               prop = drm_property_create_enum(dev, DRM_MODE_PROP_ENUM,
> >> +                                               "DP_Colorspace", dp_colorspace,
> >> +                                               ARRAY_SIZE(dp_colorspace));
> >> +               if (!prop)
> >> +                       return -ENOMEM;
> >
> >Why different names for DP/HDMI?
> There are some colorspaces specific to HDMI and DP, hence we created separate properties
> for these encoders.

Why does that require different names for the props?

> This is just to expose DP specifc colorspaces on a DP connector and same way
> for HDMI. Earlier, we had just one but it was giving DP stuff as well to a HDMI Connector and vice-versa
> which was not looking good.
> 
> Regards,
> Uma Shankar
> >-Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel