[Intel-gfx] [PATCH 2/2] drm/i915: Re-enable fastset by default

Rodrigo Vivi rodrigo.vivi at intel.com
Tue Nov 20 22:29:00 UTC 2018


On Tue, Nov 20, 2018 at 02:40:49PM +0100, Maarten Lankhorst wrote:
> Now that we've solved the backlight issue, I think it's time to enable
> this again by default. We've enabled it in the past, but backlight
> issues prevented us from enabling it by default.
> 
> Our hardware readout is pretty complete, and with all of the connector
> state moved to atomic I'm hoping we finally have enough capability to
> re-enable fastset by default.
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 7e56c516c815..149ab592a695 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -57,7 +57,7 @@ struct drm_printer;
>  	/* leave bools at the end to not create holes */ \
>  	param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
>  	param(bool, enable_hangcheck, true) \
> -	param(bool, fastboot, false) \
> +	param(bool, fastboot, true) \

Do we know the impact of this on PSR, FBC and DRRS?

Last time that I checked a while ago this would break
this features since they just get enabled right after pipe
getting enabled.

>  	param(bool, prefault_disable, false) \
>  	param(bool, load_detect_test, false) \
>  	param(bool, force_reset_modeset_test, false) \
> -- 
> 2.19.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list