[Intel-gfx] [PATCH] drm/i915/selftests: Log test and subtest names for easier debugging

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Nov 21 09:43:42 UTC 2018


On 21/11/2018 09:33, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-11-21 09:02:18)
>>
>> On 20/11/2018 18:18, Tvrtko Ursulin wrote:
>>> I can certainly send a patch for -DDEBUG, seems like that would be the
>>> correct thing to do for all selftests.
>>
>> I've changed my mind - I think it is more desirable to actually just do
>> what this patch did and convert test start messages to pr_info.
>>
>> To enable all pr_debug by default, even if compiled with i915 debugging
>> on, doesn't seem conceptually correct. There might be ones which are
>> prohibitively noisy and in any case it would defeat the point of dynamic
>> debug.
> 
> Nah, I still consider this to be test infra debug noise, and pr_debug()
> quite apt for describing that.

Shrug. A few lines in the see of noise, I don't see any harm but just 
bringing it to the same state as IGT run logs.

> And for the task you have, nothing more than a wild goose chase.

That one has been parked for now, these are all just after effects.

Regards,

Tvrtko



More information about the Intel-gfx mailing list