[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,v11,01/23] drm/dsc: Modify DRM helper to return complete DSC color depth capabilities

Tue Nov 27 18:47:07 UTC 2018

== Series Details ==

Series: series starting with [CI,v11,01/23] drm/dsc: Modify DRM helper to return complete DSC color depth capabilities
URL   : https://patchwork.freedesktop.org/series/53097/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b564f4b939ca drm/dsc: Modify DRM helper to return complete DSC color depth capabilities
66a26c5082ff drm/dsc: Define Display Stream Compression PPS infoframe
-:31: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 342 lines checked
2c62da01daa8 drm/dsc: Define VESA Display Stream Compression Capabilities
-:34: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-developed-by:
#34: 
Co-developed-by: Gaurav K Singh <gaurav.k.singh at intel.com>

-:73: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#73: FILE: include/drm/drm_dsc.h:40:
+	bool convert_rgb;

-:83: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#83: FILE: include/drm/drm_dsc.h:50:
+	bool enable422;

-:108: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#108: FILE: include/drm/drm_dsc.h:75:
+	bool block_pred_enable;

-:136: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#136: FILE: include/drm/drm_dsc.h:103:
+	bool vbr_enable;

-:151: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#151: FILE: include/drm/drm_dsc.h:118:
+	bool native_422;

-:153: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#153: FILE: include/drm/drm_dsc.h:120:
+	bool native_420;

total: 0 errors, 1 warnings, 6 checks, 121 lines checked
c270fd909ad4 drm/dsc: Define Rate Control values that do not change over configurations
-:42: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Srivatsa, Anusha <anusha.srivatsa at intel.com>'

total: 0 errors, 1 warnings, 0 checks, 12 lines checked
71de78c19cd0 drm/dsc: Add helpers for DSC picture parameter set infoframes
-:79: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#79: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 285 lines checked
259e70ec73c9 drm/dsc: Define the DSC 1.1 and 1.2 Line Buffer depth constants
dd433139c981 drm/i915/dp: Add DSC params and DSC config to intel_crtc_state
-:49: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#49: FILE: drivers/gpu/drm/i915/intel_drv.h:943:
+		bool compression_enable;

-:50: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#50: FILE: drivers/gpu/drm/i915/intel_drv.h:944:
+		bool dsc_split;

total: 0 errors, 0 warnings, 2 checks, 22 lines checked
8f8c03228817 drm/i915/dp: Compute DSC pipe config in atomic check
-:189: WARNING:LINE_SPACING: Missing a blank line after declarations
#189: FILE: drivers/gpu/drm/i915/intel_dp.c:1924:
+		u8 dsc_dp_slice_count;
+		dsc_max_output_bpp =

-:263: WARNING:TABSTOP: Statements should start on a tabstop
#263: FILE: drivers/gpu/drm/i915/intel_dp.c:2025:
+	 else

total: 0 errors, 2 warnings, 0 checks, 262 lines checked
410642768023 drm/i915/dp: Do not enable PSR2 if DSC is enabled
b250f4133544 drm/i915/dsc: Define & Compute VESA DSC params
-:68: WARNING:BAD_SIGN_OFF: Non-standard signature: Co-developed-by:
#68: 
Co-developed-by: Manasi Navare <manasi.d.navare at intel.com>

-:95: WARNING:MISSING_SPACE: break quoted strings at a space character
#95: FILE: drivers/gpu/drm/i915/intel_dp.c:1957:
+		DRM_DEBUG_KMS("Cannot compute valid DSC parameters for Input Bpp = %d"
+			      "Compressed BPP = %d\n",

-:119: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#119: 
new file mode 100644

-:405: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#405: FILE: drivers/gpu/drm/i915/intel_vdsc.c:282:
+}
+};

total: 0 errors, 3 warnings, 1 checks, 496 lines checked
7ac193d4beba drm/i915/dsc: Compute Rate Control parameters for DSC
-:141: CHECK:SPACING: space preferred before that '*' (ctx:VxE)
#141: FILE: drivers/gpu/drm/i915/intel_vdsc.c:411:
+				vdsc_cfg->slice_bpg_offset)*
 				                           ^

-:173: CHECK:LINE_SPACING: Please don't use multiple blank lines
#173: FILE: drivers/gpu/drm/i915/intel_vdsc.c:443:
+
+

total: 0 errors, 0 warnings, 2 checks, 136 lines checked
3fe1eaeafcc1 drm/i915/dp: Enable/Disable DSC in DP Sink
738d3e39b498 drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI
4489512d99cc drm/i915/dp: Configure i915 Picture parameter Set registers during DSC enabling
-:48: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#48: FILE: drivers/gpu/drm/i915/i915_drv.h:3346:
+extern void intel_dsc_enable(struct intel_encoder *encoder,

-:347: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#347: FILE: drivers/gpu/drm/i915/intel_vdsc.c:853:
+		rc_buf_thresh_dword[i/4] |= (u32)(vdsc_cfg->rc_buf_thresh[i] <<
 		                     ^

-:350: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#350: FILE: drivers/gpu/drm/i915/intel_vdsc.c:856:
+			 rc_buf_thresh_dword[i/4]);
 			                      ^

-:391: WARNING:LONG_LINE: line over 100 characters
#391: FILE: drivers/gpu/drm/i915/intel_vdsc.c:897:
+		rc_range_params_dword[i/2] |= (u32)(((vdsc_cfg->rc_range_params[i].range_bpg_offset <<

-:391: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#391: FILE: drivers/gpu/drm/i915/intel_vdsc.c:897:
+		rc_range_params_dword[i/2] |= (u32)(((vdsc_cfg->rc_range_params[i].range_bpg_offset <<
 		                       ^

-:398: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#398: FILE: drivers/gpu/drm/i915/intel_vdsc.c:904:
+			 rc_range_params_dword[i/2]);
 			                        ^

-:476: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#476: FILE: drivers/gpu/drm/i915/intel_vdsc.c:982:
+{
+

-:483: WARNING:RETURN_VOID: void function return statements are not generally useful
#483: FILE: drivers/gpu/drm/i915/intel_vdsc.c:989:
+	return;
+}

total: 0 errors, 2 warnings, 6 checks, 429 lines checked
cd379836e433 drm/i915/dp: Use the existing write_infoframe() for DSC PPS SDPs
76ff0de57bbb drm/i915/dp: Populate DSC PPS SDP and send PPS infoframes
b480353d8479 drm/i915/dp: Configure Display stream splitter registers during DSC enable
0b918115e1f4 drm/i915/dp: Disable DSC in source by disabling DSS CTL bits
-:35: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#35: FILE: drivers/gpu/drm/i915/i915_drv.h:3348:
+extern void intel_dsc_disable(const struct intel_crtc_state *crtc_state);

-:91: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#91: FILE: drivers/gpu/drm/i915/intel_vdsc.c:1063:
+
+}

total: 0 errors, 0 warnings, 2 checks, 50 lines checked
8c2f974809b9 drm/i915/dsc: Enable and disable appropriate power wells for VDSC
96008331f00c i915/dp/fec: Add fec_enable to the crtc state.
-:125: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#125: FILE: drivers/gpu/drm/i915/intel_drv.h:951:
+	bool fec_enable;

total: 0 errors, 0 warnings, 1 checks, 64 lines checked
43c49d130d57 drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION
d9355283d266 i915/dp/fec: Configure the Forward Error Correction bits.
0c1f2afef9c5 drm/i915/fec: Disable FEC state.