[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 29 13:51:55 UTC 2018


== Series Details ==

Series: series starting with [1/2] drm/i915/backlight: Restore backlight on resume (rev2)
URL   : https://patchwork.freedesktop.org/series/53239/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
65214d12d27f drm/i915/backlight: Restore backlight on resume
bbcaa34deb24 drm/i915/backlight: Fix backlight takeover on LPT, v2.
-:67: CHECK:BRACES: braces {} should be used on all arms of this statement
#67: FILE: drivers/gpu/drm/i915/intel_panel.c:1517:
+	if (cpu_mode) {
[...]
+	} else
[...]

-:81: WARNING:LONG_LINE: line over 100 characters
#81: FILE: drivers/gpu/drm/i915/intel_panel.c:1531:
+			      val, freq, lpt_hz_to_pwm(connector, freq), panel->backlight.min, panel->backlight.max);

-:84: CHECK:BRACES: Unbalanced braces around else statement
#84: FILE: drivers/gpu/drm/i915/intel_panel.c:1534:
+	} else

total: 0 errors, 1 warnings, 2 checks, 62 lines checked



More information about the Intel-gfx mailing list