[Intel-gfx] [PATCH] drm/i915/icl: Remove Wa_1604302699

Mika Kuoppala mika.kuoppala at linux.intel.com
Thu Nov 29 13:56:03 UTC 2018


Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com> writes:

> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> It seems that the documentation does not reference this any more, plus,
> bit 28 does not stick when written to the register.
>
> Therefore I can only assume this is something which was documented in the
> past but got removed from the hardware in the meantime.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_workarounds.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
> index 39cd1f823ea9..e5cd6c6c66c3 100644
> --- a/drivers/gpu/drm/i915/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/intel_workarounds.c
> @@ -882,11 +882,6 @@ static void icl_gt_workarounds_apply(struct drm_i915_private *dev_priv)
>  		   I915_READ(SUBSLICE_UNIT_LEVEL_CLKGATE) |
>  		   GWUNIT_CLKGATE_DIS);
>  
> -	/* Wa_1604302699:icl */
> -	I915_WRITE(GEN10_L3_CHICKEN_MODE_REGISTER,
> -		   I915_READ(GEN10_L3_CHICKEN_MODE_REGISTER) |
> -		   GEN11_I2M_WRITE_DISABLE);
> -
>  	/* Wa_1406838659:icl (pre-prod) */
>  	if (IS_ICL_REVID(dev_priv, ICL_REVID_A0, ICL_REVID_B0))
>  		I915_WRITE(INF_UNIT_LEVEL_CLKGATE,
> -- 
> 2.19.1


More information about the Intel-gfx mailing list