[Intel-gfx] [PATCH 2/3] drm/i915: Remove bogus FIXME from SKL wm computation

Rodrigo Vivi rodrigo.vivi at intel.com
Fri Nov 30 06:28:30 UTC 2018


On Tue, Nov 13, 2018 at 07:23:29PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> We do return an error when the watermark calculation fails, so
> the FIXME claiming otherwise is outdated. Remove it.
> 
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 6426af873cef..5d823bdc63a9 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5458,10 +5458,6 @@ skl_compute_wm(struct drm_atomic_state *state)
>  	 * Note that the DDB allocation above may have added more CRTC's that
>  	 * weren't otherwise being modified (and set bits in dirty_pipes) if
>  	 * pipe allocations had to change.
> -	 *
> -	 * FIXME:  Now that we're doing this in the atomic check phase, we
> -	 * should allow skl_update_pipe_wm() to return failure in cases where
> -	 * no suitable watermark values can be found.
>  	 */
>  	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, cstate, i) {
>  		struct intel_crtc_state *intel_cstate =
> -- 
> 2.18.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list