[Intel-gfx] [PATCH 8/8] drm/i915: Trim unused workaround list entries

Chris Wilson chris at chris-wilson.co.uk
Fri Nov 30 11:49:05 UTC 2018


Quoting Tvrtko Ursulin (2018-11-30 11:32:01)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> The new workaround list allocator grows the list in chunks so will end up
> with some unused space. Trim it when the initialization phase is done to
> free up a tiny bit of slab.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_workarounds.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_workarounds.c b/drivers/gpu/drm/i915/intel_workarounds.c
> index de2bddbc64b4..abfe4b530c23 100644
> --- a/drivers/gpu/drm/i915/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/intel_workarounds.c
> @@ -55,6 +55,19 @@ static void wa_init_start(struct i915_wa_list *wal, const char *name)
>  
>  static void wa_init_finish(struct i915_wa_list *wal)
>  {
> +       /* Trim unused entries. */
> +       if (wal->count < wal->__size) {
> +               struct i915_wa *wa =
> +                       kcalloc(wal->count, sizeof(*wa), GFP_KERNEL);

kcalloc followed by memcpy, what have you done with Tvrtko?
kmemdup ?
-Chris


More information about the Intel-gfx mailing list