[Intel-gfx] [PATCH 6/8] drm/i915: Move register white-listing to the common workaround framework

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Nov 30 15:16:52 UTC 2018


On 30/11/2018 11:45, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-11-30 11:31:59)
>> -static void whitelist_reg(struct whitelist *w, i915_reg_t reg)
>> +static void
>> +whitelist_reg(struct i915_wa_list *wal, i915_reg_t reg)
>>   {
>> -       if (GEM_DEBUG_WARN_ON(w->count >= RING_MAX_NONPRIV_SLOTS))
>> -               return;
>> -
>> -       w->reg[w->count++] = reg;
>> -}
>> +       struct i915_wa wa = {
>> +               .reg = reg
>> +       };
>>   
>> -static void bdw_whitelist_build(struct whitelist *w)
>> -{
>> -}
>> +       if (GEM_WARN_ON(wal->count >= RING_MAX_NONPRIV_SLOTS))
> 
> We only need this code for pre-merge testing of patches as the build
> list is static.

I interpret this as change to GEM_DEBUG_WARN_ON - makes sense.

Regards,

Tvrtko


More information about the Intel-gfx mailing list