[Intel-gfx] [PATCH 6/7] drm/i915: Fuse per-context workaround handling with the common framework

[Chris Wilson]

Quoting Tvrtko Ursulin (2018-11-30 17:44:11)
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
> index 91a750e90dc4..8f985c35ec92 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
> @@ -452,6 +452,7 @@ struct intel_engine_cs {
>  
>         struct intel_hw_status_page status_page;
>         struct i915_ctx_workarounds wa_ctx;
> +       struct i915_wa_list ctx_wa_list;
>         struct i915_wa_list wa_list;
>         struct i915_wa_list whitelist;

Hmm. I think I would suggest we use

ctx_wa_list
mmio_wa_list ???
whitelist

> -int intel_ctx_workarounds_init(struct drm_i915_private *dev_priv)
> +void intel_ctx_workarounds_init(struct drm_i915_private *dev_priv)
>  {
> -       int err = 0;
> +       struct i915_wa_list *wal = &dev_priv->engine[RCS]->ctx_wa_list;

And here,

intel_engine_init_ctx_wa(intel_engine_cs *engine)

or something to match the other engine wa_list.
-Chris