[Intel-gfx] [PATCH 4/7] drm/i915/selftests: Add tests for GT and engine workaround verification

Chris Wilson chris at chris-wilson.co.uk
Fri Nov 30 22:01:51 UTC 2018


Quoting Chris Wilson (2018-11-30 21:04:46)
> Quoting Tvrtko Ursulin (2018-11-30 17:44:09)
> > From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > 
> > Two simple selftests which test that both GT and engine workarounds are
> > not lost after either a full GPU reset, or after the per-engine ones.
> > 
> > (Including checks that one engine reset is not affecting workarounds not
> > belonging to itself.)
> > 
> > v2:
> >  * Rebase for series refactoring.
> >  * Add spinner for actual engine reset!
> >  * Add idle reset test as well. (Chris Wilson)
> >  * Share existing global_reset_lock. (Chris Wilson)
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > ---
> > +       for_each_engine(engine, i915, id) {
> > +               bool ok;
> > +
> > +               pr_info("Verifying after %s reset...\n", engine->name);
> > +
> > +               igt_global_reset_lock(i915);
> 
> The key thing with it being global, is that you can take it globally :)

I think that tidies up the loop innards to make it worthwhile, so with
that
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list