[Intel-gfx] [PATCH 13/18] drm/vc4: Use drm_atomic_helper_shutdown

Eric Anholt eric at anholt.net
Wed Oct 3 20:31:18 UTC 2018


Daniel Vetter <daniel.vetter at ffwll.ch> writes:

> drm_plane_helper_disable is a non-atomic drivers only function, and
> will blow up (since no one passes the locking context it needs).
>
> Atomic drivers which want to quiescent their hw on unload should
> use drm_atomic_helper_shutdown() instead.
>
> v2: Rebase.

I've definitely never tested unload.

Looks like we could drop vc4_plane_destroy() entirely?  Regardless,
acked-by.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20181003/b3c4d5d7/attachment.sig>


More information about the Intel-gfx mailing list