[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Stop calling intel_opregion unregister/register in suspend/resume

Patchwork patchwork at emeril.freedesktop.org
Fri Oct 5 18:18:02 UTC 2018


== Series Details ==

Series: drm/i915: Stop calling intel_opregion unregister/register in suspend/resume
URL   : https://patchwork.freedesktop.org/series/50630/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
eca8408fd83c drm/i915: Stop calling intel_opregion unregister/register in suspend/resume
-:162: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#162: FILE: drivers/gpu/drm/i915/intel_opregion.c:1083:
+		 * We don't actually need to do anything with them. */

-:214: WARNING:NEEDLESS_IF: kfree(NULL) is safe and this check is probably not required
#214: FILE: drivers/gpu/drm/i915/intel_opregion.c:1135:
+	if (opregion->vbt_firmware) {
+		kfree(opregion->vbt_firmware);

total: 0 errors, 2 warnings, 0 checks, 223 lines checked



More information about the Intel-gfx mailing list