[Intel-gfx] [PATCH] drm/i915: nuke the intel_lvds_connector
kbuild test robot
lkp at intel.com
Wed Oct 10 01:59:01 UTC 2018
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.19-rc7 next-20181009]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-nuke-the-intel_lvds_connector/20181010-092805
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x000-201840 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
drivers/gpu/drm/i915/intel_lvds.c: In function 'intel_lvds_destroy':
>> drivers/gpu/drm/i915/intel_lvds.c:481:3: error: implicit declaration of function 'to_lvds_connector'; did you mean 'to_intel_connector'? [-Werror=implicit-function-declaration]
to_lvds_connector(connector);
^~~~~~~~~~~~~~~~~
to_intel_connector
>> drivers/gpu/drm/i915/intel_lvds.c:481:3: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
>> drivers/gpu/drm/i915/intel_lvds.c:483:36: error: dereferencing pointer to incomplete type 'struct intel_lvds_connector'
if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
^~
cc1: some warnings being treated as errors
vim +481 drivers/gpu/drm/i915/intel_lvds.c
79e53945 Jesse Barnes 2008-11-07 470
79e53945 Jesse Barnes 2008-11-07 471 /**
79e53945 Jesse Barnes 2008-11-07 472 * intel_lvds_destroy - unregister and free LVDS structures
79e53945 Jesse Barnes 2008-11-07 473 * @connector: connector to free
79e53945 Jesse Barnes 2008-11-07 474 *
79e53945 Jesse Barnes 2008-11-07 475 * Unregister the DDC bus for this connector then free the driver private
79e53945 Jesse Barnes 2008-11-07 476 * structure.
79e53945 Jesse Barnes 2008-11-07 477 */
79e53945 Jesse Barnes 2008-11-07 478 static void intel_lvds_destroy(struct drm_connector *connector)
79e53945 Jesse Barnes 2008-11-07 479 {
db1740a0 Jani Nikula 2012-10-19 480 struct intel_lvds_connector *lvds_connector =
db1740a0 Jani Nikula 2012-10-19 @481 to_lvds_connector(connector);
79e53945 Jesse Barnes 2008-11-07 482
9cd300e0 Jani Nikula 2012-10-19 @483 if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
9cd300e0 Jani Nikula 2012-10-19 484 kfree(lvds_connector->base.edid);
9cd300e0 Jani Nikula 2012-10-19 485
1d508706 Jani Nikula 2012-10-19 486 intel_panel_fini(&lvds_connector->base.panel);
aaa6fd2a Matthew Garrett 2011-08-12 487
79e53945 Jesse Barnes 2008-11-07 488 drm_connector_cleanup(connector);
79e53945 Jesse Barnes 2008-11-07 489 kfree(connector);
79e53945 Jesse Barnes 2008-11-07 490 }
79e53945 Jesse Barnes 2008-11-07 491
:::::: The code at line 481 was first introduced by commit
:::::: db1740a0f1a1d60391f60cfd93083f3c091d398a drm/i915/lvds: Move the acpi_lid_notifier from drm_i915_private to the connector
:::::: TO: Jani Nikula <jani.nikula at intel.com>
:::::: CC: Daniel Vetter <daniel.vetter at ffwll.ch>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 29789 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20181010/51082e31/attachment-0001.gz>
More information about the Intel-gfx
mailing list