[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Add OA buffer size uAPI parameter

[Patchwork]

== Series Details ==

Series: drm/i915/perf: Add OA buffer size uAPI parameter
URL   : https://patchwork.freedesktop.org/series/50810/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a82d071538ce drm/i915/perf: remove redundant oa buffer initialization
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
gen[78]_oa_enable), so we don't need to initialize when preparing the metric

total: 0 errors, 1 warnings, 0 checks, 53 lines checked
08fd704be37c drm/i915/perf: pass stream to vfuncs when possible
b8b8e91b7a92 drm/i915/perf: do not warn when OA buffer is already allocated
-:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#8: 
will see that OA buffer has already been allocated, while a previous process

total: 0 errors, 1 warnings, 0 checks, 18 lines checked
1744e940bee4 drm/i915/perf: add a parameter to control the size of OA buffer
-:44: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'tail' may be better as '(tail)' to avoid precedence issues
#44: FILE: drivers/gpu/drm/i915/i915_perf.c:215:
+#define OA_TAKEN(tail, head)	((tail - head) & (dev_priv->perf.oa.oa_buffer.size - 1))

-:44: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'head' may be better as '(head)' to avoid precedence issues
#44: FILE: drivers/gpu/drm/i915/i915_perf.c:215:
+#define OA_TAKEN(tail, head)	((tail - head) & (dev_priv->perf.oa.oa_buffer.size - 1))

-:182: ERROR:CODE_INDENT: code indent should use tabs where possible
#182: FILE: drivers/gpu/drm/i915/i915_perf.c:1507:
+        BUG_ON(size < SZ_128K || size > SZ_16M);$

-:182: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#182: FILE: drivers/gpu/drm/i915/i915_perf.c:1507:
+        BUG_ON(size < SZ_128K || size > SZ_16M);$

-:182: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#182: FILE: drivers/gpu/drm/i915/i915_perf.c:1507:
+        BUG_ON(size < SZ_128K || size > SZ_16M);

-:325: ERROR:CODE_INDENT: code indent should use tabs where possible
#325: FILE: include/uapi/drm/i915_drm.h:1543:
+        /**$

-:326: ERROR:CODE_INDENT: code indent should use tabs where possible
#326: FILE: include/uapi/drm/i915_drm.h:1544:
+         * Specify a global OA buffer size to be allocated in bytes.$

-:327: ERROR:CODE_INDENT: code indent should use tabs where possible
#327: FILE: include/uapi/drm/i915_drm.h:1545:
+         * The driver will allocate a HW supported size that is at$

-:328: ERROR:CODE_INDENT: code indent should use tabs where possible
#328: FILE: include/uapi/drm/i915_drm.h:1546:
+         * least as large as specified by this property. Larger sizes$

-:329: ERROR:CODE_INDENT: code indent should use tabs where possible
#329: FILE: include/uapi/drm/i915_drm.h:1547:
+         * than what the HW supports will fail.$

-:330: ERROR:CODE_INDENT: code indent should use tabs where possible
#330: FILE: include/uapi/drm/i915_drm.h:1548:
+         */$

-:331: ERROR:CODE_INDENT: code indent should use tabs where possible
#331: FILE: include/uapi/drm/i915_drm.h:1549:
+        DRM_I915_PERF_PROP_OA_BUFFER_SIZE,$

-:331: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#331: FILE: include/uapi/drm/i915_drm.h:1549:
+        DRM_I915_PERF_PROP_OA_BUFFER_SIZE,$

total: 8 errors, 3 warnings, 2 checks, 280 lines checked