[Intel-gfx] [PATCH] drm/i915: Fix i915_driver_init_mmio error path

Chris Wilson chris at chris-wilson.co.uk
Thu Oct 11 12:26:24 UTC 2018


Quoting Michal Wajdeczko (2018-10-11 13:19:51)
> In case of the error we missed to call i915_mmio_cleanup
> that matches earlier call to i915_mmio_setup.

True, doesn't look fatal atm; worst being we left the register bar mmapped
(which would be ok as we map it again using the same constraints on next
load) and left the mchbar flagged as active (if we enabled it on
i915/i965).

We should pair this with a patch to add a i915_inject_load_failure() to
intel_engine_init_mmio.
 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list