[Intel-gfx] [PATCH] drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set

[Ville Syrjälä]

On Mon, Oct 15, 2018 at 12:58:56PM +0100, Chris Wilson wrote:
> Since we peek into HW state and poke around, it behoves us to acquire a
> runtime pm wakeref beforehand.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108364
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 7b7f844d325b..80dec5740de0 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -4187,6 +4187,7 @@ i915_drop_caches_set(void *data, u64 val)
>  
>  	DRM_DEBUG("Dropping caches: 0x%08llx [0x%08llx]\n",
>  		  val, val & DROP_ALL);
> +	intel_runtime_pm_get(i915);
>  
>  	if (val & DROP_RESET_ACTIVE && !intel_engines_are_idle(i915))
>  		i915_gem_set_wedged(i915);
> @@ -4246,6 +4247,8 @@ i915_drop_caches_set(void *data, u64 val)
>  	if (val & DROP_FREED)
>  		i915_gem_drain_freed_objects(i915);
>  
> +	intel_runtime_pm_put(i915);
> +

I see some other rpm get/put calls inside this function. Drop those?

Either way
Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

>  	return ret;
>  }
>  
> -- 
> 2.19.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel