[Intel-gfx] [PATCH 3/3] drm/i915/icl: Disable master intr before reading

Mika Kuoppala mika.kuoppala at linux.intel.com
Tue Oct 16 10:39:10 UTC 2018


Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com> writes:

> On 15/10/18 07:14, Mika Kuoppala wrote:
>> Disable master interrupt before reading level indications.
>> This will close a race where we get a level indication between
>> reading and disabling, generating an extra interrupt where we
>> could have avoided one.
>> 
>> Further, as the reading acts also as a post, replace the
>> write/post on the irq reset with the helper. On enabling side,
>> posting doesn't serve any purpose so it can also be replaced
>> with helper.
>> 
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>> Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
>> ---
>
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

All 3 patches pushed. Thank you all for review.
-Mika


More information about the Intel-gfx mailing list