[Intel-gfx] [PATCH] drm/i915/huc: Normalize HuC status returned by I915_PARAM_HAS_HUC

[Michał Winiarski]

On Tue, Oct 16, 2018 at 11:34:14AM +0000, Michal Wajdeczko wrote:
> In response for I915_PARAM_HAS_HUC we are returning value that
> indicates if HuC firmware was loaded and verified. However, our
> previously used positive value was based on specific register bit
> which is about to change on future platform. Let's normalize our
> return values to 0 and 1 before clients will start to use Gen9 value.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Michal Winiarski <michal.winiarski at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Haihao Xiang <haihao.xiang at intel.com>

It's "tweaking" the ABI, but hopefully we can avoid breaking anything.

intel-vaapi-driver is doing !!(getparam) and media-driver is being optimistic
(i.e. assuming that HuC is present without any checks).

I don't know of any other components using this, and as you've mentioned in the
commit message - HuC is still under unsafe param, so:

Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

-Michał

> ---
>  drivers/gpu/drm/i915/intel_huc.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)