[Intel-gfx] [PATCH v3] drm/i915/guc: doorbell checking cleanup

[Michal Wajdeczko]

On Fri, 19 Oct 2018 01:10:10 +0200, Daniele Ceraolo Spurio  
<daniele.ceraolospurio at intel.com> wrote:

> A collection of very small cleanups/improvements around doorbell checking
> that do not deserve their own patch:
>
> - Move doorbell-related HW defs to intel_guc_reg.h
>
> - use GUC_NUM_DOORBELLS instead of GUC_DOORBELL_INVALID where
>   appropriate
>
> - do not stop on error in guc_verify_doorbells
>
> - do not print drbreg on error: the only content of the register
>   apart from the valid bit is the lower part of the physical memory
>   address, which we can't use even if valid because we don't know
>   which descriptor it came from (since the doorbell is in an unexpected
>   state)
>
> - Move the checking of doorbell valid bit to a common helper.
>
> v2: add more cleanups (move defs, use GUC_NUM_DOORBELLS, don't stop in
>     guc_verify_doorbells) (Michal)
>
> v3: move more things to intel_guc_reg, redefine
>     GUC_DOORBELL_INVALID (Michal), drop guc_doorbell_qw since it just
>     duplicates guc_doorbell_info
>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> ---

Reviewed-by: Michal Wajdeczko <michal.wajdeczko at intel.com>

Thanks,
Michal