[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start

Patchwork patchwork at emeril.freedesktop.org
Tue Oct 23 08:03:49 UTC 2018


== Series Details ==

Series: drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start
URL   : https://patchwork.freedesktop.org/series/51362/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e6ef08e9dafb drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18: 
References: 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")

-:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")'
#18: 
References: 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")

-:83: ERROR:LOCKING: recursive locking is bad, do not use this ever.
#83: FILE: drivers/gpu/drm/i915/i915_gem_userptr.c:84:
+	switch (mutex_trylock_recursive(m)) {

-:111: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#111: FILE: drivers/gpu/drm/i915/i915_gem_userptr.c:107:
+	struct mutex *unlock;

total: 2 errors, 1 warnings, 1 checks, 228 lines checked



More information about the Intel-gfx mailing list