[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: fix deadlock of syncobj v6

Patchwork patchwork at emeril.freedesktop.org
Tue Oct 23 10:05:25 UTC 2018


== Series Details ==

Series: drm: fix deadlock of syncobj v6
URL   : https://patchwork.freedesktop.org/series/51369/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
268f7a66feea drm: fix deadlock of syncobj v6
-:44: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'syncobj->type == DRM_SYNCOBJ_TYPE_TIMELINE'
#44: FILE: drivers/gpu/drm/drm_syncobj.c:115:
+	if ((syncobj->type == DRM_SYNCOBJ_TYPE_TIMELINE) &&
+	    (point <= syncobj->timeline)) {

-:44: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'point <= syncobj->timeline'
#44: FILE: drivers/gpu/drm/drm_syncobj.c:115:
+	if ((syncobj->type == DRM_SYNCOBJ_TYPE_TIMELINE) &&
+	    (point <= syncobj->timeline)) {

-:66: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'syncobj->type == DRM_SYNCOBJ_TYPE_BINARY'
#66: FILE: drivers/gpu/drm/drm_syncobj.c:137:
+		if ((syncobj->type == DRM_SYNCOBJ_TYPE_BINARY) &&
+		    (point != signal_pt->value))

-:66: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'point != signal_pt->value'
#66: FILE: drivers/gpu/drm/drm_syncobj.c:137:
+		if ((syncobj->type == DRM_SYNCOBJ_TYPE_BINARY) &&
+		    (point != signal_pt->value))

-:326: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#326: FILE: include/drm/drm_syncobj.h:80:
+	spinlock_t pt_lock;

total: 0 errors, 0 warnings, 5 checks, 286 lines checked



More information about the Intel-gfx mailing list