[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: GTT remapping for display (rev5)

Patchwork patchwork at emeril.freedesktop.org
Tue Oct 23 16:21:30 UTC 2018


== Series Details ==

Series: drm/i915: GTT remapping for display (rev5)
URL   : https://patchwork.freedesktop.org/series/50165/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7ecc46df21aa drm/i915: Make sure fb gtt offsets stay within 32bits
-:44: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'B' - possible side-effects?
#44: FILE: drivers/gpu/drm/i915/i915_utils.h:57:
+#define add_overflows(A, B) \
+	add_overflows_t(typeof((A) + (B)), (A), (B))

total: 0 errors, 0 warnings, 1 checks, 50 lines checked
e7d9b84981c9 drm/i915: Decouple SKL stride units from intel_fb_stride_alignment()
2a232ab75fe1 drm/i915: Add a new "remapped" gtt_view
-:177: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#177: FILE: drivers/gpu/drm/i915/i915_gem_gtt.h:193:
+	BUILD_BUG_ON(sizeof(struct intel_remapped_info) != 9*sizeof(unsigned int));
 	                                                    ^

total: 0 errors, 0 warnings, 1 checks, 231 lines checked
ee777eb6655c drm/i915/selftests: Add mock selftest for remapped vmas
-:114: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#114: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:493:
+	for (t = types; *t; t++) {
 	for (a = planes; a->width; a++) {

-:132: WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#132: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:554:
+						if (view.type == I915_GGTT_VIEW_ROTATED)

-:133: WARNING:LONG_LINE: line over 100 characters
#133: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:555:
+							sg = assert_rotated(obj, &view.rotated, n, sg);

-:134: WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#134: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:556:
+						else

-:135: WARNING:LONG_LINE: line over 100 characters
#135: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:557:
+							sg = assert_remapped(obj, &view.remapped, n, sg);

total: 0 errors, 5 warnings, 0 checks, 129 lines checked
d2f2a9c684e0 drm/i915/selftests: Add live vma selftest
45bb3b57aa21 drm/i915: Overcome display engine stride limits via GTT remapping
0439f5d5b684 drm/i915: Bump gen4+ fb stride limit to 256KiB
-:40: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#40: FILE: drivers/gpu/drm/i915/intel_display.c:2489:
+		return 256*1024;
 		          ^

total: 0 errors, 0 warnings, 1 checks, 19 lines checked
fa36cffdcccc drm/i915: Bump gen7+ fb size limits to 16kx16k



More information about the Intel-gfx mailing list