[Intel-gfx] [PATCH 3/3] drm/i915/icl: Add get_config functionality for dsi

[Kulkarni, Vandita]

> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Sent: Tuesday, October 23, 2018 5:39 PM
> To: Kulkarni, Vandita <vandita.kulkarni at intel.com>
> Cc: intel-gfx at lists.freedesktop.org; Nikula, Jani <jani.nikula at intel.com>;
> Chauhan, Madhav <madhav.chauhan at intel.com>
> Subject: Re: [PATCH 3/3] drm/i915/icl: Add get_config functionality for dsi
> 
> On Tue, Oct 23, 2018 at 04:39:14PM +0530, Vandita Kulkarni wrote:
> > From: Madhav Chauhan <madhav.chauhan at intel.com>
> >
> > This patch implements the functionality for getting PIPE configuration
> > to which DSI encoder is connected. Used during the atomic modeset.
> >
> > v2: use intel_dsi_bitrate instead of intel_dsi->pclk
> >
> > Signed-off-by: Madhav Chauhan <madhav.chauhan at intel.com>
> > Signed-off-by: Vandita Kulkarni <vandita.kulkarni at intel.com>
> > ---
> >  drivers/gpu/drm/i915/icl_dsi.c | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/icl_dsi.c
> > b/drivers/gpu/drm/i915/icl_dsi.c index d2bb369..6cb3bf8 100644
> > --- a/drivers/gpu/drm/i915/icl_dsi.c
> > +++ b/drivers/gpu/drm/i915/icl_dsi.c
> > @@ -665,3 +665,16 @@ static void __attribute__((unused))
> >  	/* step6d: enable dsi transcoder */
> >  	gen11_dsi_enable_transcoder(encoder);
> >  }
> > +
> > +static void __attribute__((unused))
> > +gen11_dsi_get_config(struct intel_encoder *encoder,
> > +				 struct intel_crtc_state *pipe_config) {
> > +	struct intel_dsi *intel_dsi = container_of(encoder, struct intel_dsi,
> > +						   base);
> > +	u32 pixel_clk;
> > +
> > +	pixel_clk = intel_dsi_bitrate(intel_dsi);
> > +	pipe_config->base.adjusted_mode.crtc_clock = pixel_clk;
> > +	pipe_config->port_clock = pixel_clk;
> 
> We're supposed to read the state from the hardware here. See how other DDI
> encoders do it.
Ok.

Thanks,
Vandita
> 
> > +}
> > --
> > 1.9.1
> 
> --
> Ville Syrjälä
> Intel