[Intel-gfx] [PATCH 1/6] drm/dp_mst: Deprecate drm_dp_find_vcpi_slots()

[Daniel Vetter]

On Tue, Oct 23, 2018 at 07:12:46PM -0400, Lyude Paul wrote:
> Because we have drm_dp_atomic_find_vcpi_slots(), which actually takes
> care to update the atomic state of the MST topology, prints valuable
> debugging output, and actually takes references to the ports it's
> checking! This explains some incorrect usage I've been seeing across the
> tree...
> 
> Signed-off-by: Lyude Paul <lyude at redhat.com>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 5ff1d79b86c4..8c3cfac437f4 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -2569,9 +2569,16 @@ struct edid *drm_dp_mst_get_edid(struct drm_connector *connector, struct drm_dp_
>  EXPORT_SYMBOL(drm_dp_mst_get_edid);
>  
>  /**
> - * drm_dp_find_vcpi_slots() - find slots for this PBN value
> + * drm_dp_find_vcpi_slots() - Find VCPI slots for this PBN value
>   * @mgr: manager to use
>   * @pbn: payload bandwidth to convert into slots.
> + *
> + * Calculate the number of VCPI slots that will be required for the given PBN
> + * value. This function is deprecated, and should not be used in atomic
> + * drivers.
> + *
> + * RETURNS:
> + * The total slots required for this port, or error.
>   */

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

>  int drm_dp_find_vcpi_slots(struct drm_dp_mst_topology_mgr *mgr,
>  			   int pbn)
> -- 
> 2.17.2
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch