[Intel-gfx] [PATCH] drm/i915: Use intel_panel_actually_set_backlight() to disable PWM backlight
Chris Wilson
chris at chris-wilson.co.uk
Wed Oct 24 16:02:18 UTC 2018
Quoting Ville Syrjala (2018-10-24 16:52:08)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Use intel_panel_actually_set_backlight() instead of a direct
> call to pwm_config() in pwm_disable_backlight().
>
> The main benefit is consistent debug logging when we turn off the
> backlight. Currently we see nothing in dmesg which made me wonder
> whether the backlight was even getting turned off properly.
>
> The second benefit is consistency; This is what we do for all
> the other backlight implementations.
It will also have the effect of calling
intel_panel_compute_brightness(0) which one presumes is desired?
Just worrying if the inverted brightness quirk is ever used with pwm.
-Chris
More information about the Intel-gfx
mailing list