[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start (rev2)

Patchwork patchwork at emeril.freedesktop.org
Thu Oct 25 13:32:37 UTC 2018


== Series Details ==

Series: drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start (rev2)
URL   : https://patchwork.freedesktop.org/series/51362/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7c70af9afdbf drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18: 
References: 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")

-:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")'
#18: 
References: 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")

-:178: ERROR:LOCKING: recursive locking is bad, do not use this ever.
#178: FILE: drivers/gpu/drm/i915/i915_gem_userptr.c:108:
+	switch (mutex_trylock_recursive(m)) {

-:256: WARNING:LONG_LINE: line over 100 characters
#256: FILE: drivers/gpu/drm/i915/i915_gem_userptr.c:176:
+				unlock = __i915_mutex_lock_recursive(&mn->mm->i915->drm.struct_mutex);

total: 2 errors, 2 warnings, 0 checks, 380 lines checked



More information about the Intel-gfx mailing list