[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Make number of ddi ports explicit.

Patchwork patchwork at emeril.freedesktop.org
Fri Oct 26 23:37:35 UTC 2018


== Series Details ==

Series: series starting with [1/3] drm/i915: Make number of ddi ports explicit.
URL   : https://patchwork.freedesktop.org/series/51634/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a961fba149af drm/i915: Make number of ddi ports explicit.
b844d4b37a60 drm/i915: Prefer direct IS_CANNONLAKE over IS_CNL_WITH_PORT_F
2cd2f0e5ad67 drm/i915: Use the ddi_ports info to kill ugly CNL_WITH_PORT_F.
-:124: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#124: FILE: include/drm/i915_pciids.h:450:
+#define INTEL_CNL_PORTF_IDS(info) \
 	INTEL_VGA_DEVICE(0x5A54, info), \
 	INTEL_VGA_DEVICE(0x5A5C, info), \
 	INTEL_VGA_DEVICE(0x5A44, info), \

-:124: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#124: FILE: include/drm/i915_pciids.h:450:
+#define INTEL_CNL_PORTF_IDS(info) \
 	INTEL_VGA_DEVICE(0x5A54, info), \
 	INTEL_VGA_DEVICE(0x5A5C, info), \
 	INTEL_VGA_DEVICE(0x5A44, info), \

total: 1 errors, 0 warnings, 1 checks, 71 lines checked



More information about the Intel-gfx mailing list