[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/selftests: Test vm isolation (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Oct 29 13:13:06 UTC 2018


== Series Details ==

Series: series starting with [1/4] drm/i915/selftests: Test vm isolation (rev2)
URL   : https://patchwork.freedesktop.org/series/51663/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1b3dc084cdde drm/i915/selftests: Test vm isolation
-:241: WARNING:LINE_SPACING: Missing a blank line after declarations
#241: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:980:
+	struct drm_file *file;
+	I915_RND_STATE(prng);

total: 0 errors, 1 warnings, 0 checks, 330 lines checked
5b80cd2d2c3e drm/i915/gtt: Record the scratch pte
c55548f46915 drm/i915/gtt: Reuse the read-only 64KiB scratch page and directories
2882f16c3e0a drm/i915/userptr: Avoid struct_mutex recursion for mmu_invalidate_range_start
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18: 
References: 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")

-:18: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")'
#18: 
References: 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers")

-:218: ERROR:LOCKING: recursive locking is bad, do not use this ever.
#218: FILE: drivers/gpu/drm/i915/i915_gem_userptr.c:108:
+	switch (mutex_trylock_recursive(m)) {

total: 2 errors, 1 warnings, 0 checks, 423 lines checked



More information about the Intel-gfx mailing list