[Intel-gfx] [PATCH v3 2/4] drm/i915/icl: Implement Display WA_1405510057

[Rodrigo Vivi]

On Tue, Oct 30, 2018 at 01:45:02AM -0700, Radhakrishna Sripada wrote:
> Display WA_1405510057 asks to not enable YUV 420 HDMI
> 10bpc when horizontal blank size mod 8 reminder is 2.
> 
> V2: Rebase(r-b: Anusha)
> V3: crtc_state->s/ycbcr420/output_format/
> 
> Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada at intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 129b880bce64..6c6c4dd12fd5 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1595,6 +1595,8 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
>  	struct drm_atomic_state *state = crtc_state->base.state;
>  	struct drm_connector_state *connector_state;
>  	struct drm_connector *connector;
> +	const struct drm_display_mode *adjusted_mode =
> +		&crtc_state->base.adjusted_mode;
>  	int i;
>  
>  	if (HAS_GMCH_DISPLAY(dev_priv))
> @@ -1643,7 +1645,14 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
>  
>  	/* Display WA #1139: glk */
>  	if (bpc == 12 && IS_GLK_REVID(dev_priv, 0, GLK_REVID_A1) &&
> -	    crtc_state->base.adjusted_mode.htotal > 5460)
> +	    adjusted_mode->htotal > 5460)
> +		return false;
> +
> +	/* Display Wa_1405510057:icl */
> +	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 &&
> +	    bpc == 10 && IS_ICELAKE(dev_priv) &&
> +	    (adjusted_mode->crtc_hblank_end -
> +	     adjusted_mode->crtc_hblank_start) % 8 == 2)
>  		return false;
>  
>  	return true;
> -- 
> 2.9.3
>