[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm: Add drm/drm_util.h header file (rev2)

Patchwork patchwork at emeril.freedesktop.org
Wed Sep 5 18:39:02 UTC 2018 

== Series Details ==

Series: series starting with [1/7] drm: Add drm/drm_util.h header file (rev2)
URL   : https://patchwork.freedesktop.org/series/49184/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ef536308c993 drm: Add drm/drm_util.h header file
-:144: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#144: 
new file mode 100644

-:149: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#149: FILE: include/drm/drm_util.h:1:
+/*

-:178: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
#178: FILE: include/drm/drm_util.h:30:
+#define for_each_if(condition) if (!(condition)) {} else

-:178: WARNING:BRACES: braces {} are not necessary for single statement blocks
#178: FILE: include/drm/drm_util.h:30:
+#define for_each_if(condition) if (!(condition)) {} else

total: 1 errors, 3 warnings, 0 checks, 105 lines checked
c6a2e00f8ca5 drm: Drop drmP.h from drm_connector.c
-:56: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 30 lines checked
6d4da8841fd5 drm: drop drmP.h include from drm_plane.c
-:94: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 55 lines checked
cc8a1f89a3b1 drm: drop drmP.h include from drm_crtc.c
-:35: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 17 lines checked
00332fdfbdca drm/atomic: trim driver interface/docs
-:88: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#88: FILE: drivers/gpu/drm/drm_atomic.c:501:
+static int drm_atomic_crtc_set_property(struct drm_crtc *crtc,
 		struct drm_crtc_state *state, struct drm_property *property,

-:202: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#202: FILE: drivers/gpu/drm/drm_atomic.c:1253:
+static int drm_atomic_set_writeback_fb_for_connector(

-:342: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 0 errors, 1 warnings, 2 checks, 301 lines checked
d4aedeb40f21 drm: Update todo.rst
4ec94773c551 drm: extract drm_atomic_uapi.c
-:1515: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#1515: 
new file mode 100644

-:1520: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#1520: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1:
+/*

-:1569: WARNING:TYPO_SPELLING: 'similiar' may be misspelled - perhaps 'similar'?
#1569: FILE: drivers/gpu/drm/drm_atomic_uapi.c:50:
+ * for load detect or similiar.

-:1600: ERROR:CODE_INDENT: code indent should use tabs where possible
#1600: FILE: drivers/gpu/drm/drm_atomic_uapi.c:81:
+^I^I                                 sizeof(umode),$

-:1600: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1600: FILE: drivers/gpu/drm/drm_atomic_uapi.c:81:
+			drm_property_create_blob(state->crtc->dev,
+		                                 sizeof(umode),

-:1601: ERROR:CODE_INDENT: code indent should use tabs where possible
#1601: FILE: drivers/gpu/drm/drm_atomic_uapi.c:82:
+^I^I                                 &umode);$

-:1634: ERROR:CODE_INDENT: code indent should use tabs where possible
#1634: FILE: drivers/gpu/drm/drm_atomic_uapi.c:115:
+                                      struct drm_property_blob *blob)$

-:1634: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1634: FILE: drivers/gpu/drm/drm_atomic_uapi.c:115:
+                                      struct drm_property_blob *blob)$

-:1877: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1877: FILE: drivers/gpu/drm/drm_atomic_uapi.c:358:
+static int set_out_fence_for_connector(struct drm_atomic_state *state,
+					struct drm_connector *connector,

-:1917: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!new_blob"
#1917: FILE: drivers/gpu/drm/drm_atomic_uapi.c:398:
+		if (new_blob == NULL)

-:1939: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1939: FILE: drivers/gpu/drm/drm_atomic_uapi.c:420:
+static int drm_atomic_crtc_set_property(struct drm_crtc *crtc,
+		struct drm_crtc_state *state, struct drm_property *property,

-:1947: CHECK:BRACES: braces {} should be used on all arms of this statement
#1947: FILE: drivers/gpu/drm/drm_atomic_uapi.c:428:
+	if (property == config->prop_active)
[...]
+	else if (property == config->prop_mode_id) {
[...]
+	} else if (property == config->degamma_lut_property) {
[...]
+	} else if (property == config->ctm_property) {
[...]
+	} else if (property == config->gamma_lut_property) {
[...]
+	} else if (property == config->prop_out_fence_ptr) {
[...]
+	} else if (crtc->funcs->atomic_set_property) {
[...]
+	} else {
[...]

-:1957: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1957: FILE: drivers/gpu/drm/drm_atomic_uapi.c:438:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->degamma_lut,

-:1965: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1965: FILE: drivers/gpu/drm/drm_atomic_uapi.c:446:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->ctm,

-:1973: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1973: FILE: drivers/gpu/drm/drm_atomic_uapi.c:454:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->gamma_lut,

-:1991: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1991: FILE: drivers/gpu/drm/drm_atomic_uapi.c:472:
+		return crtc->funcs->atomic_set_property(crtc, state, property, val);
+	} else {

-:2003: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2003: FILE: drivers/gpu/drm/drm_atomic_uapi.c:484:
+drm_atomic_crtc_get_property(struct drm_crtc *crtc,
+		const struct drm_crtc_state *state,

-:2030: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2030: FILE: drivers/gpu/drm/drm_atomic_uapi.c:511:
+static int drm_atomic_plane_set_property(struct drm_plane *plane,
+		struct drm_plane_state *state, struct drm_property *property,

-:2038: WARNING:LINE_SPACING: Missing a blank line after declarations
#2038: FILE: drivers/gpu/drm/drm_atomic_uapi.c:519:
+		struct drm_framebuffer *fb = drm_framebuffer_lookup(dev, NULL, val);
+		drm_atomic_set_fb_for_plane(state, fb);

-:2054: WARNING:LINE_SPACING: Missing a blank line after declarations
#2054: FILE: drivers/gpu/drm/drm_atomic_uapi.c:535:
+		struct drm_crtc *crtc = drm_crtc_find(dev, NULL, val);
+		return drm_atomic_set_crtc_for_plane(state, crtc);

-:2103: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2103: FILE: drivers/gpu/drm/drm_atomic_uapi.c:584:
+drm_atomic_plane_get_property(struct drm_plane *plane,
+		const struct drm_plane_state *state,

-:2109: WARNING:BRACES: braces {} are not necessary for any arm of this statement
#2109: FILE: drivers/gpu/drm/drm_atomic_uapi.c:590:
+	if (property == config->prop_fb_id) {
[...]
+	} else if (property == config->prop_in_fence_fd) {
[...]
+	} else if (property == config->prop_crtc_id) {
[...]
+	} else if (property == config->prop_crtc_x) {
[...]
+	} else if (property == config->prop_crtc_y) {
[...]
+	} else if (property == config->prop_crtc_w) {
[...]
+	} else if (property == config->prop_crtc_h) {
[...]
+	} else if (property == config->prop_src_x) {
[...]
+	} else if (property == config->prop_src_y) {
[...]
+	} else if (property == config->prop_src_w) {
[...]
+	} else if (property == config->prop_src_h) {
[...]
+	} else if (property == plane->alpha_property) {
[...]
+	} else if (property == plane->blend_mode_property) {
[...]
+	} else if (property == plane->rotation_property) {
[...]
+	} else if (property == plane->zpos_property) {
[...]
+	} else if (property == plane->color_encoding_property) {
[...]
+	} else if (property == plane->color_range_property) {
[...]
+	} else if (plane->funcs->atomic_get_property) {
[...]
+	} else {
[...]

-:2164: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2164: FILE: drivers/gpu/drm/drm_atomic_uapi.c:645:
+static int drm_atomic_set_writeback_fb_for_connector(

-:2186: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2186: FILE: drivers/gpu/drm/drm_atomic_uapi.c:667:
+static int drm_atomic_connector_set_property(struct drm_connector *connector,
+		struct drm_connector_state *state, struct drm_property *property,

-:2194: WARNING:LINE_SPACING: Missing a blank line after declarations
#2194: FILE: drivers/gpu/drm/drm_atomic_uapi.c:675:
+		struct drm_crtc *crtc = drm_crtc_find(dev, NULL, val);
+		return drm_atomic_set_crtc_for_connector(state, crtc);

-:2254: WARNING:LINE_SPACING: Missing a blank line after declarations
#2254: FILE: drivers/gpu/drm/drm_atomic_uapi.c:735:
+		int ret = drm_atomic_set_writeback_fb_for_connector(state, fb);
+		if (fb)

-:2277: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2277: FILE: drivers/gpu/drm/drm_atomic_uapi.c:758:
+drm_atomic_connector_get_property(struct drm_connector *connector,
+		const struct drm_connector_state *state,

-:2337: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2337: FILE: drivers/gpu/drm/drm_atomic_uapi.c:818:
+int drm_atomic_get_property(struct drm_mode_object *obj,
+		struct drm_property *property, uint64_t *val)

-:2345: WARNING:LINE_SPACING: Missing a blank line after declarations
#2345: FILE: drivers/gpu/drm/drm_atomic_uapi.c:826:
+		struct drm_connector *connector = obj_to_connector(obj);
+		WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));

-:2347: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2347: FILE: drivers/gpu/drm/drm_atomic_uapi.c:828:
+		ret = drm_atomic_connector_get_property(connector,
+				connector->state, property, val);

-:2352: WARNING:LINE_SPACING: Missing a blank line after declarations
#2352: FILE: drivers/gpu/drm/drm_atomic_uapi.c:833:
+		struct drm_crtc *crtc = obj_to_crtc(obj);
+		WARN_ON(!drm_modeset_is_locked(&crtc->mutex));

-:2354: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2354: FILE: drivers/gpu/drm/drm_atomic_uapi.c:835:
+		ret = drm_atomic_crtc_get_property(crtc,
+				crtc->state, property, val);

-:2359: WARNING:LINE_SPACING: Missing a blank line after declarations
#2359: FILE: drivers/gpu/drm/drm_atomic_uapi.c:840:
+		struct drm_plane *plane = obj_to_plane(obj);
+		WARN_ON(!drm_modeset_is_locked(&plane->mutex));

-:2361: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2361: FILE: drivers/gpu/drm/drm_atomic_uapi.c:842:
+		ret = drm_atomic_plane_get_property(plane,
+				plane->state, property, val);

-:2376: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#2376: FILE: drivers/gpu/drm/drm_atomic_uapi.c:857:
+static struct drm_pending_vblank_event *create_vblank_event(

-:2381: WARNING:SIZEOF_PARENTHESIS: sizeof *e should be sizeof(*e)
#2381: FILE: drivers/gpu/drm/drm_atomic_uapi.c:862:
+	e = kzalloc(sizeof *e, GFP_KERNEL);

-:2466: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2466: FILE: drivers/gpu/drm/drm_atomic_uapi.c:947:
+		ret = drm_atomic_connector_set_property(connector,
+				connector_state, prop, prop_value);

-:2480: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2480: FILE: drivers/gpu/drm/drm_atomic_uapi.c:961:
+		ret = drm_atomic_crtc_set_property(crtc,
+				crtc_state, prop, prop_value);

-:2494: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2494: FILE: drivers/gpu/drm/drm_atomic_uapi.c:975:
+		ret = drm_atomic_plane_set_property(plane,
+				plane_state, prop, prop_value);

-:2510: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'?
#2510: FILE: drivers/gpu/drm/drm_atomic_uapi.c:991:
+ * between devices. A Fence or a group of fences are transfered to/from

-:2582: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2582: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1063:
+static int prepare_signaling(struct drm_device *dev,
+				  struct drm_atomic_state *state,

-:2789: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2789: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1270:
+	if ((arg->flags & DRM_MODE_PAGE_FLIP_ASYNC) &&
+			!dev->mode_config.async_page_flip)

-:2794: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2794: FILE: drivers/gpu/drm/drm_atomic_uapi.c:1275:
+	if ((arg->flags & DRM_MODE_ATOMIC_TEST_ONLY) &&
+			(arg->flags & DRM_MODE_PAGE_FLIP_EVENT))

-:3079: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#3079: FILE: include/drm/drm_atomic_uapi.h:1:
+/*

-:3136: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'

total: 3 errors, 17 warnings, 25 checks, 2458 lines checked

More information about the Intel-gfx mailing list