[Intel-gfx] [PATCH 02/21] drm/i915/guc: Don't allow GuC submission on pre-Gen11

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Thu Sep 6 08:29:34 UTC 2018


Quoting Michal Wajdeczko (2018-08-29 22:10:36)
> Upcoming Gen11 GuC firmware requires new interface that is incompatible
> with existing pre-Gen11 firmwares. Updated firmwares for pre-Gen11 will
> arrive later. In the meantime sanitize the enable_guc option so that we
> can enable HuC authentication but nothing else on pre-Gen11.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Michel Thierry <michel.thierry at intel.com>
> Cc: John Spotswood <john.a.spotswood at intel.com>
> Cc: Vinay Belgaumkar <vinay.belgaumkar at intel.com>
> Cc: Tony Ye <tony.ye at intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
> Cc: Jeff Mcgee <jeff.mcgee at intel.com>
> Cc: Antonio Argenziano <antonio.argenziano at intel.com>
> Cc: Sujaritha Sundaresan <sujaritha.sundaresan at intel.com>

<SNIP>

> @@ -292,6 +301,12 @@ int intel_uc_init(struct drm_i915_private *i915)
>                 return ret;
>  
>         if (USES_GUC_SUBMISSION(i915)) {
> +

Extra newline.

Regards, Joonas

> +               if (INTEL_GEN(i915) < 11) {
> +                       intel_guc_fini(guc);
> +                       return -EIO;
> +               }
> +


More information about the Intel-gfx mailing list