[Intel-gfx] [PATCH 3/3] drm/i915/csr: bypass firmware request on i915.dmc_firmware_path=""

[Chris Wilson]

Quoting Jani Nikula (2018-09-06 09:21:26)
> With i915.dmc_firmware_path="" it's obvious the intention is to disable
> CSR firmware loading. Bypass the firmware request altogether in this
> case, with more obvious debug logging.
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_csr.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 956ac8bbf5e4..dbaeffddb5e7 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -476,6 +476,12 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv)
>         }
>  
>         if (i915_modparams.dmc_firmware_path) {
> +               if (strlen(i915_modparams.dmc_firmware_path) == 0) {
> +                       csr->fw_path = NULL;
> +                       DRM_DEBUG_KMS("Disabling CSR firmare and runtime PM\n");

In response to a user parameter, could even be DRM_INFO().
-Chris