[Intel-gfx] [igt-dev] [PATCH i-g-t] lib: Cancel all outstanding requests at the end of a test

Chris Wilson chris at chris-wilson.co.uk
Fri Sep 7 16:44:05 UTC 2018


Quoting Antonio Argenziano (2018-09-07 17:37:45)
> 
> 
> On 07/09/18 01:41, Chris Wilson wrote:
> > Quite often on catastrophic failure the test leaves a long queue of
> > unterminated batches pending execution. Each runs until hangcheck fires
> > and skips onto the next, leaving us waiting for a very long time at test
> > exit.
> > 
> > On older kernels, this gracefully degrades into the existing mechanism.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> LGTM. Just, if I have to be really picky, the comment for 
> quiescent_gpu() says it is installed as an exit handler.

It's still correct in spirit. But no caller of quiescent_gpu() cares
because they need it for idling right there and then.
-Chris


More information about the Intel-gfx mailing list