[Intel-gfx] [PATCH] drm/i915: Nuke struct_mutex from context_setparam

Chris Wilson chris at chris-wilson.co.uk
Tue Sep 11 13:14:38 UTC 2018


Quoting Chris Wilson (2018-09-11 13:50:22)
> Userspace should be free to race against itself and shoot itself in
> the foot if it so desires to adjust a parameter at the same time as
> submitting a batch to that context. As such, the struct_mutex in context
> setparam is only being used to serialise userspace against itself and
> not for any protection of internal structs and so is superfluous.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

To reduce the amount of queasiness here, we should split off the
ctx->flags and ctx->user_flags.
-Chris


More information about the Intel-gfx mailing list