[Intel-gfx] [PATCH 2/4] drm/i915/fbdev: Use i915/drm_i915_private consistently

Rodrigo Vivi rodrigo.vivi at intel.com
Thu Sep 13 21:37:59 UTC 2018


On Thu, Sep 13, 2018 at 10:31:18PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2018-09-13 22:11:11)
> > On Thu, Sep 13, 2018 at 02:16:27PM +0100, Chris Wilson wrote:
> > > Convert the interface (except for the drm core callback) to accept
> > > drm_i915_private as that is our native type of the majority of
> > > operations.
> >
> > this message just tells about s/dev/dev_priv...
>
> What is dev_priv? To me, it talks about i915.

well, 2 separated things:

1. when I wrote this I was just referring to that info_fbdev change...
that is not reflected here on this message I'm afraid and that
could be a separated patch...

----

2. about the other comment related to dev_priv vs i915
your patch has this:

-     ret = intel_fbdev_init(dev);
+     ret = intel_fbdev_init(dev_priv);

so, why not just i915 here as well?

> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list