[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gen11: Enable planar format support on gen11.

Patchwork patchwork at emeril.freedesktop.org
Fri Sep 21 18:17:19 UTC 2018


== Series Details ==

Series: drm/i915/gen11: Enable planar format support on gen11.
URL   : https://patchwork.freedesktop.org/series/50031/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0f2019e00594 drm/i915/gen11: Enable 6 sprites on gen11
06f6be3d4c6f drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v3.
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18: 
- Put all the state updating login in intel_plane_atomic_check_with_state().

-:29: WARNING:BAD_SIGN_OFF: Duplicate signature
#29: 
Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

-:72: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#72: FILE: drivers/gpu/drm/i915/intel_atomic_plane.c:159:
+	struct intel_crtc *crtc = to_intel_crtc(

-:84: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#84: FILE: drivers/gpu/drm/i915/intel_atomic_plane.c:171:
+		/*
+		* Make sure a previously linked plane (and implicitly, the CRTC)

-:268: CHECK:BOOL_MEMBER: Avoid using bool structure members because of possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
#268: FILE: drivers/gpu/drm/i915/intel_drv.h:560:
+	bool slave;

-:289: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#289: FILE: drivers/gpu/drm/i915/intel_drv.h:1358:
+intel_atomic_get_plane_state(struct intel_atomic_state *state,
+				 struct intel_plane *plane)

total: 0 errors, 3 warnings, 3 checks, 303 lines checked
ef7832b117a3 drm/i915/gen11: Handle watermarks correctly for separate Y/UV planes.
-:90: WARNING:LINE_SPACING: Missing a blank line after declarations
#90: FILE: drivers/gpu/drm/i915/intel_pm.c:4319:
+			enum plane_id aux = plane_state->linked_plane->id;
+			minimum[aux] = skl_ddb_min_alloc(pstate, 0);

total: 0 errors, 1 warnings, 0 checks, 213 lines checked
0ef08e8bfaa7 drm/i915/gen11: Program the scalers correctly for planar formats.
-:45: CHECK:BRACES: Unbalanced braces around else statement
#45: FILE: drivers/gpu/drm/i915/intel_atomic.c:243:
+		} else

total: 0 errors, 0 warnings, 1 checks, 122 lines checked
4c0ba802d583 drm/i915/gen11: Program the chroma upsampler for HDR planes.
-:46: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects?
#46: FILE: drivers/gpu/drm/i915/i915_reg.h:6719:
+#define PLANE_CUS_CTL(pipe, plane)   \
+	_MMIO_PLANE(plane, _PLANE_CUS_CTL_1(pipe), _PLANE_CUS_CTL_2(pipe))

total: 0 errors, 0 warnings, 1 checks, 68 lines checked
f4123b47f50c drm/i915/gen11: Program the Y and UV plane for planar mode correctly.
133d16ffd6ab drm/i915/gen11: Expose planar format support on gen11.
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 28 lines checked



More information about the Intel-gfx mailing list