[Intel-gfx] [PATCH v2 2/2] drm/i915: Remove i915.enable_ppgtt override

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon Sep 24 12:30:23 UTC 2018


Quoting Chris Wilson (2018-09-22 17:18:04)
> Now that we are confident in providing full-ppgtt where supported,
> remove the ability to override the context isolation.
> 
> v2: Remove faked aliasing-ppgtt for testing as it no longer is accepted.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Matthew Auld <matthew.auld at intel.com>

<SNIP>

> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 8624b4bdc242..28f77810bc47 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2593,9 +2593,13 @@ intel_info(const struct drm_i915_private *dev_priv)
>  
>  #define HAS_EXECLISTS(dev_priv) HAS_LOGICAL_RING_CONTEXTS(dev_priv)
>  
> -#define USES_PPGTT(dev_priv)           (i915_modparams.enable_ppgtt)
> -#define USES_FULL_PPGTT(dev_priv)      (i915_modparams.enable_ppgtt >= 2)
> -#define USES_FULL_48BIT_PPGTT(dev_priv)        (i915_modparams.enable_ppgtt == 3)

Maybe INTEL_PPGTT(dev_priv) accessor for consistency.

Also, after this a mechanical patch for s/USES_PPGTT/HAS_PPGTT/ might be
in place as HAS means USES, too.

Looks good otherwise, but this removes the condition that GVT-g doesn't
support 32-bit ppGTT. So that needs a respin.

Regards, Joonas


More information about the Intel-gfx mailing list