[Intel-gfx] [PATCH 4/8] drm/i915/psr: Remove PSR2 TODO error handling

dhinakaran.pandiyan at gmail.com dhinakaran.pandiyan at gmail.com
Tue Sep 25 06:26:22 UTC 2018


On Thu, 2018-09-20 at 13:43 -0700, José Roberto de Souza wrote:
> We are already handling all PSR2 errors, so we can drop this TODO.

Yes, we can remove it to thanks to all the work you have been doing.

Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan>

> 
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_psr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_psr.c
> b/drivers/gpu/drm/i915/intel_psr.c
> index b4edbbda8d71..0dd4211cb293 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -1127,8 +1127,6 @@ void intel_psr_short_pulse(struct intel_dp
> *intel_dp)
>  		intel_psr_disable_locked(intel_dp);
>  	/* clear status register */
>  	drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_ERROR_STATUS,
> val);
> -
> -	/* TODO: handle PSR2 errors */
>  exit:
>  	mutex_unlock(&psr->lock);
>  }


More information about the Intel-gfx mailing list