[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915/selftests: Smoketest preemption

Patchwork patchwork at emeril.freedesktop.org
Tue Sep 25 09:09:39 UTC 2018


== Series Details ==

Series: series starting with [1/7] drm/i915/selftests: Smoketest preemption
URL   : https://patchwork.freedesktop.org/series/50137/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
94c8bbdc1288 drm/i915/selftests: Smoketest preemption
-:92: WARNING:LINE_SPACING: Missing a blank line after declarations
#92: FILE: drivers/gpu/drm/i915/selftests/intel_lrc.c:634:
+	enum intel_engine_id id;
+	IGT_TIMEOUT(end_time);

total: 0 errors, 1 warnings, 0 checks, 155 lines checked
db029ada9348 drm/i915/execlists: Avoid kicking priority on the current context
e77648982b5d drm/i915: Reserve some priority bits for internal use
33f522195a47 drm/i915: Combine multiple internal plists into the same i915_priolist bucket
-:166: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name
#166: FILE: drivers/gpu/drm/i915/intel_lrc.c:367:
+	struct list_head *uninitialized_var(pl);

-:284: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name
#284: FILE: drivers/gpu/drm/i915/intel_lrc.c:1180:
+	struct list_head *uninitialized_var(pl);

-:313: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#313: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:199:
+#define priolist_for_each_request(it, plist, idx) \
+	for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+		list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:313: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#313: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:199:
+#define priolist_for_each_request(it, plist, idx) \
+	for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+		list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:317: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#317: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:203:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+	for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+		list_for_each_entry_safe(it, n, \
+					 &(plist)->requests[idx - 1], \
+					 sched.link)

-:317: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#317: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:203:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+	for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+		list_for_each_entry_safe(it, n, \
+					 &(plist)->requests[idx - 1], \
+					 sched.link)

total: 0 errors, 2 warnings, 4 checks, 272 lines checked
dfcd4482c432 drm/i915: Priority boost for new clients
bb22baf4add9 drm/i915: Pull scheduling under standalone lock
-:146: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#146: 
new file mode 100644

-:151: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#151: FILE: drivers/gpu/drm/i915/i915_scheduler.c:1:
+/*

-:394: WARNING:FUNCTION_ARGUMENTS: function definition argument 'pl' should also have an identifier name
#394: FILE: drivers/gpu/drm/i915/i915_scheduler.c:244:
+	struct list_head *uninitialized_var(pl);

total: 0 errors, 3 warnings, 0 checks, 870 lines checked
000a8c39d4ba drm/i915: Priority boost for waiting clients



More information about the Intel-gfx mailing list