[Intel-gfx] [PATCH 2/2] drm/i915: Enable RGB565 90/270 plane rotation for gen11 onwards.

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Tue Sep 25 14:38:46 UTC 2018


On 25.09.2018 16:35, Maarten Lankhorst wrote:
> Op 05-09-18 om 16:58 schreef Ville Syrjälä:
>> On Mon, Aug 27, 2018 at 03:37:53PM +0300, Juha-Pekka Heikkila wrote:
>>>  From gen11 onwards RGB565 90/270 plane rotation is supported on hardware.
>>>
>>> IGT: https://patchwork.freedesktop.org/series/48756/
>>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
>>> ---
>>>   drivers/gpu/drm/i915/intel_atomic_plane.c | 9 ++++++---
>>>   1 file changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu/drm/i915/intel_atomic_plane.c
>>> index 344a16b..c245906 100644
>>> --- a/drivers/gpu/drm/i915/intel_atomic_plane.c
>>> +++ b/drivers/gpu/drm/i915/intel_atomic_plane.c
>>> @@ -123,14 +123,17 @@ static bool intel_plane_valid_rotation(const struct drm_plane_state *plane_state
>>>   		}
>>>   
>>>   		/*
>>> -		 * 90/270 is not allowed with RGB64 16:16:16:16,
>>> -		 * RGB 16-bit 5:6:5, and Indexed 8-bit.
>>> +		 * 90/270 is not allowed with RGB64 16:16:16:16 and
>>> +		 * Indexed 8-bit. RGB 16-bit. 5:6:5 is allowed gen11 onwards.
>>                                              ^
>> Extra period there
>>
>> Otherwise lgtm
>> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Thanks, pushed.
> 
> Patch 1/2 is dropped because of other cleanups superceeding it, and had to rebase patch 2/2 to apply. All should be well now. :)
> 

Ok, thank you :)

/Juha-Pekka



More information about the Intel-gfx mailing list